Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/ch68743/serial-flash-windows #598

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

busticated
Copy link
Contributor

@busticated busticated commented Dec 1, 2020

Description

running the particle flash --serial tinker command on windows fails intermittently with Error writing firmware: unknown message (ch)

How to Test

using a selection of devices, first run particle usb start-listening and then particle flash --serial tinker against each at least 20 times and verify that your device is flashed appropriately and no errors are shown

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

fixes: UnhandledPromiseRejectionWarning and related deprecation warnings
fixes (node:15707) [DEP0005] DeprecationWarning: Buffer() is deprecated
@busticated busticated requested a review from monkbroc December 1, 2020 18:42
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/lib/ymodem.js Show resolved Hide resolved
@busticated busticated merged commit 2cf6aa2 into master Dec 1, 2020
@busticated busticated deleted the bugfix/ch68743/serial-flash-windows branch December 1, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants